This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
Chorus Womb Fix+Improvements #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks Parent Activation Conditions before Checking ghosts as part of child Activation Conditions
|
Probably a good idea to PR this upstream. |
Do I really want to deal with Bay's Development cycle? No. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
There was an issue with Chorus Wombs spawning the chorus. I have made the code now functional, and streamlined.
How?
Originally, it would activate, send a message to ghosts with a link, jump them to the womb, then requiring them to click on the womb to spawn, checking and draining resources as appropriate.
With this PR, clicking the on the womb is no longer needed. Click on the link in the chat and it spawns you on the womb.
I have also added some activation checks to ensure chorus don't activate the womb if there's no ghosts available for it. Decreases potential chat spam.
The Long and Short of It
Activation Checks for the Womb are properly configured.
Use of the womb from the POV of ghosts is now much simpler(and functional)
Testing Images and Procedure
Successful test(Granted I commented out the resource checks for speed's sake)
Procedure:
Spawn Growth Womb
Aghost
Advanced proc call activate()
Finished
Click on chat message
Done
Changelog
🆑 DatBoiTim
code: Chorus Womb has activation checks to decrease chat spam. Based on presence of valid ghosts to summon.
tweak: Streamlined ghost usage of Chorus wombs